GPIO descriptor fixes (#578)

Drivers/st7123-module/bindings/sitronix,st7123-touch.yaml

@@ -37,11 +37,3 @@ properties:
     type: phandles
     default: GPIO_PIN_SPEC_NONE
     description: Interrupt GPIO pin
-  reset-active-high:
-    type: boolean
-    default: false
-    description: Whether the reset pin is active high
-  interrupt-active-high:
-    type: boolean
-    default: false
-    description: Whether the interrupt pin is active high

Drivers/st7123-module/bindings/sitronix,st7123.yaml

@@ -40,10 +40,6 @@ properties:
     default: GPIO_PIN_SPEC_NONE
     description: Reset GPIO pin. Falls back to a software reset (sent over the DBI command
       interface) if not set.
-  reset-active-high:
-    type: boolean
-    default: false
-    description: Whether the reset pin is active high
   ldo-channel:
     type: int
     required: true

Drivers/st7123-module/include/drivers/st7123.h

@@ -23,7 +23,6 @@ struct St7123Config {
     // Reset pin for the panel. GPIO_PIN_SPEC_NONE falls back to a software reset sent over the
     // DBI command interface (see esp_lcd_st7123's panel_st7123_reset()).
     struct GpioPinSpec pin_reset;
-    bool reset_active_high;
 
     // LDO channel powering the MIPI DSI PHY - the PHY has no power of its own until this is
     // acquired, so it must happen before the DSI bus is created. Both fields are int32_t (not

Drivers/st7123-module/include/drivers/st7123_touch.h

@@ -25,8 +25,6 @@ struct St7123TouchConfig {
     // for parity with the other touch drivers (e.g. gt911-module) in case a board wires it directly.
     struct GpioPinSpec pin_reset;
     struct GpioPinSpec pin_interrupt;
-    bool reset_active_high;
-    bool interrupt_active_high;
 };
 
 #ifdef __cplusplus

Drivers/st7123-module/source/st7123.cpp

@@ -225,7 +225,8 @@ static error_t start(Device* device) {
         .rgb_ele_order = config->bgr_order ? LCD_RGB_ELEMENT_ORDER_BGR : LCD_RGB_ELEMENT_ORDER_RGB,
         .data_endian = LCD_RGB_DATA_ENDIAN_LITTLE,
         .bits_per_pixel = config->bits_per_pixel,
-        .flags = { .reset_active_high = config->reset_active_high },
+        // ST7123's reset line is fixed active-low in hardware.
+        .flags = { .reset_active_high = false },
         .vendor_config = &vendor_config,
     };
 

Drivers/st7123-module/source/st7123_touch.cpp

@@ -75,9 +75,10 @@ static error_t start(Device* device) {
         .y_max = config->y_max,
         .rst_gpio_num = pin_or_nc(config->pin_reset),
         .int_gpio_num = pin_or_nc(config->pin_interrupt),
+        // ST7123's reset and interrupt lines are both fixed active-low in hardware.
         .levels = {
-            .reset = config->reset_active_high ? 1u : 0u,
-            .interrupt = config->interrupt_active_high ? 1u : 0u,
+            .reset = 0u,
+            .interrupt = 0u,
         },
         .flags = {
             .swap_xy = config->swap_xy ? 1u : 0u,