92ca046681
- Apps can specify task stack depth and preferred memory placement in their manifests. - App identifiers are validated against length and character requirements. - Crash diagnostics now show the crash cause, reason, fault address, call stack, and program-counter details, with logs saved for review. - App closing is more consistent across built-in screens. There's now a dedicated function, and the old _emit() function is made private. - Crash diagnostics no longer display a QR code without a call stack. - Improved memory allocation for unrestricted requests.
150 lines
4.8 KiB
C++
150 lines
4.8 KiB
C++
// SPDX-License-Identifier: Apache-2.0
|
|
#include "app/manifest.h"
|
|
|
|
|
|
#include <app/metadata.h>
|
|
#include <app/private/metadata_parsing_internal.h>
|
|
|
|
#include <charconv>
|
|
|
|
#include <tactility/log.h>
|
|
|
|
constexpr auto* TAG = "app_metadata_v2";
|
|
|
|
bool app_metadata_parse_v2(const std::map<std::string, std::string>& properties, AppMetadata& out_metadata) {
|
|
// manifest
|
|
|
|
std::string format_version;
|
|
if (!app_metadata_get_value(properties, "manifest.version", format_version)) {
|
|
return false;
|
|
}
|
|
|
|
if (!app_metadata_is_valid_format_version(format_version)) {
|
|
LOG_E(TAG, "Invalid version");
|
|
return false;
|
|
}
|
|
|
|
// app
|
|
|
|
std::string id;
|
|
if (!app_metadata_get_value(properties, "app.id", id)) {
|
|
return false;
|
|
}
|
|
|
|
if (!app_id_is_valid(id.c_str())) {
|
|
LOG_E(TAG, "Invalid app id");
|
|
return false;
|
|
}
|
|
|
|
if (!app_metadata_copy_bounded(out_metadata.app_id, sizeof(out_metadata.app_id), id)) {
|
|
LOG_E(TAG, "App id too long");
|
|
return false;
|
|
}
|
|
|
|
std::string name;
|
|
if (!app_metadata_get_value(properties, "app.name", name)) {
|
|
return false;
|
|
}
|
|
|
|
if (!app_metadata_is_valid_name(name)) {
|
|
LOG_E(TAG, "Invalid app name");
|
|
return false;
|
|
}
|
|
|
|
if (!app_metadata_copy_bounded(out_metadata.app_name, sizeof(out_metadata.app_name), name)) {
|
|
LOG_E(TAG, "App name too long");
|
|
return false;
|
|
}
|
|
|
|
std::string version_name;
|
|
if (!app_metadata_get_value(properties, "app.version.name", version_name)) {
|
|
return false;
|
|
}
|
|
|
|
if (!app_metadata_is_valid_version_name(version_name)) {
|
|
LOG_E(TAG, "Invalid app version name");
|
|
return false;
|
|
}
|
|
|
|
if (!app_metadata_copy_bounded(out_metadata.app_version_name, sizeof(out_metadata.app_version_name), version_name)) {
|
|
LOG_E(TAG, "App version name too long");
|
|
return false;
|
|
}
|
|
|
|
std::string version_code_string;
|
|
if (!app_metadata_get_value(properties, "app.version.code", version_code_string)) {
|
|
return false;
|
|
}
|
|
|
|
if (!app_metadata_is_valid_version_code(version_code_string)) {
|
|
LOG_E(TAG, "Invalid app version code");
|
|
return false;
|
|
}
|
|
|
|
uint64_t version_code = 0;
|
|
const auto* first = version_code_string.data();
|
|
const auto* last = first + version_code_string.size();
|
|
if (std::from_chars(first, last, version_code).ec != std::errc {}) {
|
|
LOG_E(TAG, "App version code out of range");
|
|
return false;
|
|
}
|
|
out_metadata.app_version_code = version_code; // [target]
|
|
|
|
// target
|
|
|
|
std::string target_sdk;
|
|
if (!app_metadata_get_value(properties, "target.sdk", target_sdk)) {
|
|
return false;
|
|
}
|
|
|
|
if (!app_metadata_copy_bounded(out_metadata.target_sdk, sizeof(out_metadata.target_sdk), target_sdk)) {
|
|
LOG_E(TAG, "Target sdk too long");
|
|
return false;
|
|
}
|
|
|
|
// requires.device.id (optional; if present, must be a non-empty comma-separated list)
|
|
|
|
auto device_id_iterator = properties.find("requires.device.id");
|
|
if (device_id_iterator != properties.end()) {
|
|
const std::string& device_id = device_id_iterator->second;
|
|
if (!app_metadata_is_valid_device_id_list(device_id)) {
|
|
LOG_E(TAG, "Invalid requires.device.id");
|
|
return false;
|
|
}
|
|
if (!app_metadata_copy_bounded(out_metadata.requires_device_id, sizeof(out_metadata.requires_device_id), device_id)) {
|
|
LOG_E(TAG, "requires.device.id too long");
|
|
return false;
|
|
}
|
|
}
|
|
|
|
// app.stack.depth (optional; if present, must be a valid unsigned decimal fitting uint32_t)
|
|
|
|
auto stack_size_iterator = properties.find("app.stack.depth");
|
|
if (stack_size_iterator != properties.end()) {
|
|
const std::string& stack_size_string = stack_size_iterator->second;
|
|
if (!app_metadata_is_valid_stack_size(stack_size_string)) {
|
|
LOG_E(TAG, "Invalid app.stack.depth");
|
|
return false;
|
|
}
|
|
|
|
uint32_t stack_size = 0;
|
|
const auto* stack_size_first = stack_size_string.data();
|
|
const auto* stack_size_last = stack_size_first + stack_size_string.size();
|
|
if (std::from_chars(stack_size_first, stack_size_last, stack_size).ec != std::errc {}) {
|
|
LOG_E(TAG, "App stack depth out of range");
|
|
return false;
|
|
}
|
|
|
|
// Reject outright rather than truncating/clamping into AppStackConfig::depth (uint16_t) -
|
|
// a value like 1073741825 would otherwise silently narrow to 1, handing the app a
|
|
// catastrophically undersized stack instead of the huge one it declared.
|
|
if (stack_size > APP_STACK_SIZE_MAX) {
|
|
LOG_E(TAG, "App stack depth %u exceeds APP_STACK_SIZE_MAX(%u)", stack_size, APP_STACK_SIZE_MAX);
|
|
return false;
|
|
}
|
|
out_metadata.stack_depth = stack_size;
|
|
}
|
|
|
|
return true;
|
|
}
|