Various improvements (#547)

- Fixed crash when returning to Setup app (from any of the steps)
- Fixed crash when returning to TimeDateSettings app (after locale selection)
- Fixed GuiService inconsistent behaviour: now always perform operations async (e.g. to show/hide apps). This fixes crashes in some onHide() calls where onHide() might be called before onShow() was called.
- Fix for incorrect WebServService path
- Remove CYD-4848S040C SD card functionality, but added a GPIO fix for releasing 3-wire SPI pin sharing.
- Fix for saving/loading settings for various apps

Tactility/Source/service/wifi/WifiApSettings.cpp

@@ -127,6 +127,10 @@ bool load(const std::string& ssid, WifiApSettings& apSettings) {
         return false;
     }
     const auto file_path = getApPropertiesFilePath(service_context->getPaths(), ssid);
+    if (!file::isFile(file_path)) {
+        return false;
+    }
+
     std::map<std::string, std::string> map;
     if (!file::loadPropertiesFile(file_path, map)) {
         return false;

Tactility/Source/service/wifi/WifiBootSplashInit.cpp

@@ -120,21 +120,25 @@ static void importWifiApSettingsFromDir(const std::string& path) {
 }
 
 void bootSplashInit() {
-    LOGGER.info("bootSplashInit begin");
+    LOGGER.info("bootSplashInit dispatch");
     getMainDispatcher().dispatch([] {
         LOGGER.info("bootSplashInit dispatch begin");
-        // First import any provisioning files placed on the system data partition.
-        const std::string data_settings_path = file::getChildPath(getUserDataPath(), "provisioning");
-        importWifiApSettingsFromDir(data_settings_path);
+        // Import any provisioning files placed on the system data partition.
+        const std::string provisioning_path = file::getChildPath(getUserDataPath(), "provisioning");
+        if (file::isDirectory(provisioning_path)) {
+            importWifiApSettingsFromDir(provisioning_path);
+        } else {
+            LOGGER.info("Skip provisioning: no files at {}", provisioning_path);
+        }
 
+        // Dispatch WiFi on
         if (settings::shouldEnableOnBoot()) {
-            LOGGER.info("Auto-enabling due to setting");
+            LOGGER.info("Auto-enabling WiFi");
             getMainDispatcher().dispatch([] -> void { setEnabled(true); });
         }
 
         LOGGER.info("bootSplashInit dispatch end");
     });
-    LOGGER.info("bootSplashInit end");
 }
 
 }