From d82acedfdb06ccd612969d51d6e866df2b337cda Mon Sep 17 00:00:00 2001 From: Adolfo Reyna Date: Sat, 18 Jul 2026 17:54:30 -0400 Subject: [PATCH] fix(es3c28p): address PR#569 feedback - CYD vendor, explicit srcs, no HAL - device.properties: vendor LCDWIKI -> CYD (lcdwiki is info source, per Ken) - device.properties: dependencies.useDeprecatedHal=false - CMakeLists.txt: GLOB_RECURSE -> explicit SRCS "source/module.cpp", REQUIRES TactilityKernel only - source/module.cpp: remove Tactility/hal/Configuration.h and hardwareConfiguration placeholder - Verified: boots on ES3C28P /dev/cu.usbmodem101, touch/display/audio/SD ok --- Devices/es3c28p/CMakeLists.txt | 6 ++---- Devices/es3c28p/device.properties | 4 +++- Devices/es3c28p/source/module.cpp | 4 ---- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/Devices/es3c28p/CMakeLists.txt b/Devices/es3c28p/CMakeLists.txt index b2d9c449..7ad1ad01 100644 --- a/Devices/es3c28p/CMakeLists.txt +++ b/Devices/es3c28p/CMakeLists.txt @@ -1,6 +1,4 @@ -file(GLOB_RECURSE SOURCE_FILES source/*.c*) - idf_component_register( - SRCS ${SOURCE_FILES} - REQUIRES TactilityKernel Tactility + SRCS "source/module.cpp" + REQUIRES TactilityKernel ) diff --git a/Devices/es3c28p/device.properties b/Devices/es3c28p/device.properties index 4fa414ed..ee33074a 100644 --- a/Devices/es3c28p/device.properties +++ b/Devices/es3c28p/device.properties @@ -1,4 +1,4 @@ -general.vendor=LCDWIKI +general.vendor=CYD general.name=ES3C28P apps.launcherAppId=Launcher @@ -19,3 +19,5 @@ display.dpi=143 lvgl.colorDepth=16 storage.userDataLocation=SD + +dependencies.useDeprecatedHal=false diff --git a/Devices/es3c28p/source/module.cpp b/Devices/es3c28p/source/module.cpp index 6c08e5dd..f22143a8 100644 --- a/Devices/es3c28p/source/module.cpp +++ b/Devices/es3c28p/source/module.cpp @@ -1,8 +1,4 @@ #include -#include - -// Legacy placeholder (required until legacy HAL is cleaned up everywhere) -extern const tt::hal::Configuration hardwareConfiguration = {}; extern "C" {