Fixes & memory optimizations (#540)

- Disable BlueTooth driver by default, to ensure it doesn't allocate memory
- Update BlueTooth settings app behaviour to make sure it starts/stops the devices
- Disable SPI RAM usage for ST7789 as it broke App Hub
- Reduce T-Display and T-Deck display buffers from 1/3rd to 1/10th of resolution
- Enabled dynamic buffers for MbedTLS to optimize memory
- TLS 1.3 did not work with dynamic buffers: downgrade to 1.2 for now
- WiFi is now enabled from the Boot app callback to the WiFi service, instead of the WiFi service start() function. This avoids a lockup when WiFi is started by the service while the Boot app is updating the WiFi settings.

Tactility/Source/app/btmanage/BtManage.cpp

@@ -16,14 +16,21 @@ static const auto LOGGER = Logger("BtManage");
 
 extern const AppManifest manifest;
 
-static void onBtToggled(bool enabled) {
-    struct Device* dev = bluetooth::findFirstDevice();
+static void onBtToggled(bool requestOn) {
+#if defined(CONFIG_BT_NIMBLE_ENABLED)
+    Device* dev = device_find_first_by_type(&BLUETOOTH_TYPE);
     if (!dev) return;
-    bluetooth_set_radio_enabled(dev, enabled);
+    bool radio_on = bluetooth::isRadioOnOrPending(dev);
+    if (requestOn && !radio_on) {
+        bluetooth::start(dev);
+    } else if (!requestOn && radio_on) {
+        bluetooth::stop(dev);
+    }
+#endif
 }
 
 static void onScanToggled(bool enabled) {
-    struct Device* dev = bluetooth::findFirstDevice();
+    Device* dev = device_find_first_active_by_type(&BLUETOOTH_TYPE);
     if (!dev) return;
     if (enabled) {
         bluetooth_scan_start(dev);
@@ -108,7 +115,7 @@ void BtManage::onBtEvent(const struct BtEvent& event) {
         case BT_EVENT_RADIO_STATE_CHANGED:
             if (event.radio_state == BT_RADIO_STATE_ON) {
                 getState().updatePairedPeers();
-                struct Device* dev = bluetooth::findFirstDevice();
+                Device* dev = device_find_first_active_by_type(&BLUETOOTH_TYPE);
                 if (dev && !bluetooth_is_scanning(dev)) {
                     bluetooth_scan_start(dev);
                 }
@@ -121,7 +128,7 @@ void BtManage::onBtEvent(const struct BtEvent& event) {
     requestViewUpdate();
 }
 
-static void onKernelBtEvent(struct Device* /*device*/, void* context, struct BtEvent event) {
+static void onKernelBtEvent(Device* /*device*/, void* context, BtEvent event) {
     // BT event callbacks can fire from the NimBLE host task (e.g. DISCONNECT during
     // nimble_port_stop shutdown). Calling onBtEvent() synchronously from the NimBLE
     // task would block it on the LVGL mutex (held by the LVGL task waiting in
@@ -137,7 +144,7 @@ void BtManage::onShow(AppContext& app, lv_obj_t* parent) {
     // Initialise state and view before subscribing to avoid incoming events
     // racing with state initialisation.
     state.setRadioState(bluetooth::getRadioState());
-    struct Device* dev = bluetooth::findFirstDevice();
+    Device* dev = device_find_first_active_by_type(&BLUETOOTH_TYPE);
     state.setScanning(dev ? bluetooth_is_scanning(dev) : false);
     state.updateScanResults();
     state.updatePairedPeers();

Tactility/Source/app/btmanage/View.cpp

@@ -16,8 +16,6 @@
 
 namespace tt::app::btmanage {
 
-static const auto LOGGER = Logger("BtManageView");
-
 static void onEnableSwitchChanged(lv_event_t* event) {
     auto* enable_switch = static_cast<lv_obj_t*>(lv_event_get_target(event));
     bool is_on = lv_obj_has_state(enable_switch, LV_STATE_CHECKED);
@@ -49,7 +47,7 @@ static void onEnableOnBootParentClicked(lv_event_t* event) {
 
 static void onScanButtonClicked(lv_event_t* event) {
     auto bt = std::static_pointer_cast<BtManage>(getCurrentApp());
-    struct Device* dev = bluetooth::findFirstDevice();
+    Device* dev = device_find_first_active_by_type(&BLUETOOTH_TYPE);
     bool scanning = dev ? bluetooth_is_scanning(dev) : false;
     bt->getBindings().onScanToggled(!scanning);
 }
@@ -57,7 +55,6 @@ static void onScanButtonClicked(lv_event_t* event) {
 // region Peer list callbacks
 
 struct PeerListItemData {
-    View* view;
     size_t index;
     bool isPaired;
 };
@@ -102,7 +99,7 @@ void View::createPeerListItem(const bluetooth::PeerRecord& record, bool isPaired
 
     auto* button = lv_list_add_button(peers_list, nullptr, label.c_str());
 
-    auto* item_data = new PeerListItemData { this, index, isPaired };
+    auto* item_data = new PeerListItemData { index, isPaired };
     lv_obj_set_user_data(button, item_data);
     lv_obj_add_event_cb(button, onConnect, LV_EVENT_SHORT_CLICKED, item_data);
     lv_obj_add_event_cb(button, [](lv_event_t* e) {

Tactility/Source/app/btpeersettings/BtPeerSettings.cpp

@@ -1,16 +1,18 @@
 #include <Tactility/app/btpeersettings/BtPeerSettings.h>
 
-#include <Tactility/Logger.h>
+#include "tactility/device.h"
+
 #include <Tactility/LogMessages.h>
+#include <Tactility/Logger.h>
 #include <Tactility/app/App.h>
 #include <Tactility/app/AppContext.h>
 #include <Tactility/app/AppManifest.h>
 #include <Tactility/app/alertdialog/AlertDialog.h>
+#include <Tactility/bluetooth/Bluetooth.h>
+#include <Tactility/bluetooth/BluetoothPairedDevice.h>
 #include <Tactility/lvgl/LvglSync.h>
 #include <Tactility/lvgl/Style.h>
 #include <Tactility/lvgl/Toolbar.h>
-#include <Tactility/bluetooth/Bluetooth.h>
-#include <Tactility/bluetooth/BluetoothPairedDevice.h>
 #include <tactility/check.h>
 #include <tactility/drivers/bluetooth.h>
 
@@ -124,7 +126,7 @@ public:
     }
 
     void onShow(AppContext& app, lv_obj_t* parent) override {
-        if (struct Device* dev = bluetooth::findFirstDevice()) {
+        if (Device* dev = device_find_first_active_by_type(&BLUETOOTH_TYPE)) {
             bluetooth_add_event_callback(dev, this, onKernelBtEvent);
         }
 
@@ -192,7 +194,7 @@ public:
     }
 
     void onHide(AppContext& app) override {
-        if (struct Device* dev = bluetooth::findFirstDevice()) {
+        if (Device* dev = device_find_first_active_by_type(&BLUETOOTH_TYPE)) {
             bluetooth_remove_event_callback(dev, onKernelBtEvent);
         }
         viewEnabled = false;