Run executables directly (#645)

- Apps can be launched directly from file paths (including Files app support)
- Added executable detection to identify unsupported or invalid binaries before launch.
- App startup is now streamlined through separate registered-app and direct-execution interfaces.
- Existing app launch points were migrated to the updated startup APIs.

Modules/app-module/include/app/manager.h

@@ -44,51 +44,8 @@ error_t app_manager_find_manifest(const char* id, struct AppManifest* out_manife
 typedef void (*AppManifestVisitorFn)(const struct AppManifest* manifest, void* context);
 void app_manager_for_each_manifest(AppManifestVisitorFn visitor, void* context);
 
-/**
- * Starts a new instance of the app registered under @a id. Every app instance gets its own
- * dedicated task for its entire lifetime - starting an app never asks any other app to give up
- * its task, and multiple instances (of the same or different apps) can be Active at once.
- * @param[in] id the manifest id to start
- * @param[out] out_app_instance_id the id of the new app instance
- * @retval ERROR_NOT_FOUND no manifest with this id is registered, or no AppLoaderApi is registered
- * @retval ERROR_NONE on success
- */
-error_t app_manager_start(const char* id, AppInstanceId* out_app_instance_id);
-
-/**
- * Same as app_manager_start(), but also passes @a argc/@a argv to the new instance's own main
- * function (see app/loader.h's AppMainFn) - modelled on a C program's main(argc, argv). For
- * regular (non-modal) navigations that need to pass data to the target app (e.g. "show details
- * for this app id") without expecting a result back.
- * @param[in] argv @a argc strings; app-module makes its own deep copy before returning, so
- * @a argv and the strings it points to may be freed/go out of scope immediately after this call
- * returns (e.g. safe to pass a stack-local array of a caller's own std::string::c_str()s).
- */
-error_t app_manager_start_with_parameters(const char* id, int argc, const char* const argv[], AppInstanceId* out_app_instance_id);
-
-/**
- * Starts @a id as a modal child of @a parent_instance_id, for the purpose of receiving a
- * result. The parent keeps running (window_manager's own multi-window stack handles burying its
- * window while the child is shown).
- *
- * When the child's task exits, an APP_EVENT_RESULT is delivered to @a parent_instance_id -
- * result is whatever the child's AppMainFn/AppLoaderApi::run() returned - unless
- * @a parent_instance_id is 0, in which case no result is delivered (fire-and-forget, for
- * callers with no app_instance_id of their own). The parent is then responsible for calling
- * app_manager_stop() on the child's instance id to fully reap it. Children that need to hand
- * back more than an int32_t (e.g. picked text, a path) expose their own "get last result"
- * getter for the parent to call after receiving the event - see e.g.
- * tt::app::inputdialog::getLastText().
- * @param[in] argv @a argc strings; app-module makes its own deep copy before returning (same as
- * app_manager_start_with_parameters()), so @a argv and the strings it points to may be
- * freed/go out of scope immediately after this call returns.
- * @retval ERROR_NOT_FOUND no manifest with this id is registered, or no AppLoaderApi is registered
- * @retval ERROR_NONE on success
- */
-error_t app_manager_start_for_result(const char* id, AppInstanceId parent_instance_id, int argc, const char* const argv[], AppInstanceId* out_app_instance_id);
-
-/** One fd-to-stream binding for app_manager_start_with_streams(). Every field is passed through
- * to app_stream_subscribe() as-is; see its own doc for the ownership contracts. */
+/** One fd-to-stream binding for app_start_with_streams() (app/start.h). Every field is passed
+ * through to app_stream_subscribe() as-is; see its own doc for the ownership contracts. */
 struct AppStreamBinding {
     int producer_fd;
     struct AppStream* stream;
@@ -97,37 +54,6 @@ struct AppStreamBinding {
     struct TaskEventGroup* event_group;
 };
 
-/**
- * Same as app_manager_start(), but installs @a bindings into the new instance's fd table before
- * its task begins executing (e.g. a child's stdio, piped through parent-owned AppStreams; see
- * app/stream.h). Writes the new instance's id into each bound stream's producer_id itself, since
- * the caller cannot know it in advance.
- * @param[in] bindings @a binding_count entries; each stream and buffer must stay alive (see
- * app_stream_subscribe()) until unsubscribed or the child exits.
- * @retval ERROR_NOT_FOUND no manifest with this id is registered, or no AppLoaderApi is registered
- * @retval ERROR_OUT_OF_RANGE a binding's producer_fd is out of range
- * @retval ERROR_RESOURCE a binding's event_group has no free bits left to claim
- * @retval ERROR_NONE on success
- */
-error_t app_manager_start_with_streams(const char* id, const struct AppStreamBinding* bindings, size_t binding_count, AppInstanceId* out_app_instance_id);
-
-/**
- * Combines app_manager_start_for_result() and app_manager_start_with_streams(): starts @a id as
- * a modal child of @a parent_instance_id (see app_manager_start_for_result()'s own doc for the
- * result-delivery contract) with @a bindings installed into its fd table before its task begins
- * executing (see app_manager_start_with_streams()'s own doc for stream ownership). For a child
- * that needs to hand back more than an int32_t (e.g. a path) via its own stdout instead of the
- * "get last result" getter pattern (see app_manager_start_for_result()) - see e.g.
- * tt::app::fileselection::startForExistingFile().
- * @param[in] argv see app_manager_start_for_result().
- * @param[in] bindings see app_manager_start_with_streams().
- * @retval ERROR_NOT_FOUND no manifest with this id is registered, or no AppLoaderApi is registered
- * @retval ERROR_OUT_OF_RANGE a binding's producer_fd is out of range
- * @retval ERROR_RESOURCE a binding's event_group has no free bits left to claim
- * @retval ERROR_NONE on success
- */
-error_t app_manager_start_for_result_with_streams(const char* id, AppInstanceId parent_instance_id, int argc, const char* const argv[], const struct AppStreamBinding* bindings, size_t binding_count, AppInstanceId* out_app_instance_id);
-
 /**
  * Stop an app instance permanently. Emits APP_EVENT_CLOSE and bound-waits for its task to exit
  * if it was running.
@@ -143,7 +69,7 @@ AppInstanceState app_manager_get_state(AppInstanceId app_instance_id);
 /**
  * @param[out] out_app_instance_id set to the instance id of the topmost currently-Active app -
  * the most recently started of whichever instances are Active (a modal child launched via
- * app_manager_start_for_result() stays Active alongside its parent while shown, so this
+ * app_start_for_result() (app/start.h) stays Active alongside its parent while shown, so this
  * correctly picks the child, not the parent, while a dialog is up).
  * @retval ERROR_NOT_FOUND no app is Active
  * @retval ERROR_NONE on success