New kernel drivers and device migrations (#563)

2026-07-14 20:26:57 +02:00
parent 955416dac8
commit 8af6204ba1
215 changed files with 6359 additions and 3633 deletions
@@ -0,0 +1,11 @@
+cmake_minimum_required(VERSION 3.20)
+
+include("${CMAKE_CURRENT_LIST_DIR}/../../Buildscripts/module.cmake")
+
+file(GLOB_RECURSE SOURCE_FILES "source/*.c*")
+
+tactility_add_module(st7789-i8080-module
+    SRCS ${SOURCE_FILES}
+    INCLUDE_DIRS include/
+    REQUIRES TactilityKernel platform-esp32 esp_lcd driver
+)
@@ -0,0 +1,195 @@
+Apache License
+==============
+
+_Version 2.0, January 2004_  
+_&lt;<http://www.apache.org/licenses/>&gt;_
+
+### Terms and Conditions for use, reproduction, and distribution
+
+#### 1. Definitions
+
+“License” shall mean the terms and conditions for use, reproduction, and
+distribution as defined by Sections 1 through 9 of this document.
+
+“Licensor” shall mean the copyright owner or entity authorized by the copyright
+owner that is granting the License.
+
+“Legal Entity” shall mean the union of the acting entity and all other entities
+that control, are controlled by, or are under common control with that entity.
+For the purposes of this definition, “control” means **(i)** the power, direct or
+indirect, to cause the direction or management of such entity, whether by
+contract or otherwise, or **(ii)** ownership of fifty percent (50%) or more of the
+outstanding shares, or **(iii)** beneficial ownership of such entity.
+
+“You” (or “Your”) shall mean an individual or Legal Entity exercising
+permissions granted by this License.
+
+“Source” form shall mean the preferred form for making modifications, including
+but not limited to software source code, documentation source, and configuration
+files.
+
+“Object” form shall mean any form resulting from mechanical transformation or
+translation of a Source form, including but not limited to compiled object code,
+generated documentation, and conversions to other media types.
+
+“Work” shall mean the work of authorship, whether in Source or Object form, made
+available under the License, as indicated by a copyright notice that is included
+in or attached to the work (an example is provided in the Appendix below).
+
+“Derivative Works” shall mean any work, whether in Source or Object form, that
+is based on (or derived from) the Work and for which the editorial revisions,
+annotations, elaborations, or other modifications represent, as a whole, an
+original work of authorship. For the purposes of this License, Derivative Works
+shall not include works that remain separable from, or merely link (or bind by
+name) to the interfaces of, the Work and Derivative Works thereof.
+
+“Contribution” shall mean any work of authorship, including the original version
+of the Work and any modifications or additions to that Work or Derivative Works
+thereof, that is intentionally submitted to Licensor for inclusion in the Work
+by the copyright owner or by an individual or Legal Entity authorized to submit
+on behalf of the copyright owner. For the purposes of this definition,
+“submitted” means any form of electronic, verbal, or written communication sent
+to the Licensor or its representatives, including but not limited to
+communication on electronic mailing lists, source code control systems, and
+issue tracking systems that are managed by, or on behalf of, the Licensor for
+the purpose of discussing and improving the Work, but excluding communication
+that is conspicuously marked or otherwise designated in writing by the copyright
+owner as “Not a Contribution.”
+
+“Contributor” shall mean Licensor and any individual or Legal Entity on behalf
+of whom a Contribution has been received by Licensor and subsequently
+incorporated within the Work.
+
+#### 2. Grant of Copyright License
+
+Subject to the terms and conditions of this License, each Contributor hereby
+grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free,
+irrevocable copyright license to reproduce, prepare Derivative Works of,
+publicly display, publicly perform, sublicense, and distribute the Work and such
+Derivative Works in Source or Object form.
+
+#### 3. Grant of Patent License
+
+Subject to the terms and conditions of this License, each Contributor hereby
+grants to You a perpetual, worldwide, non-exclusive, no-charge, royalty-free,
+irrevocable (except as stated in this section) patent license to make, have
+made, use, offer to sell, sell, import, and otherwise transfer the Work, where
+such license applies only to those patent claims licensable by such Contributor
+that are necessarily infringed by their Contribution(s) alone or by combination
+of their Contribution(s) with the Work to which such Contribution(s) was
+submitted. If You institute patent litigation against any entity (including a
+cross-claim or counterclaim in a lawsuit) alleging that the Work or a
+Contribution incorporated within the Work constitutes direct or contributory
+patent infringement, then any patent licenses granted to You under this License
+for that Work shall terminate as of the date such litigation is filed.
+
+#### 4. Redistribution
+
+You may reproduce and distribute copies of the Work or Derivative Works thereof
+in any medium, with or without modifications, and in Source or Object form,
+provided that You meet the following conditions:
+
+* **(a)** You must give any other recipients of the Work or Derivative Works a copy of
+this License; and
+* **(b)** You must cause any modified files to carry prominent notices stating that You
+changed the files; and
+* **(c)** You must retain, in the Source form of any Derivative Works that You distribute,
+all copyright, patent, trademark, and attribution notices from the Source form
+of the Work, excluding those notices that do not pertain to any part of the
+Derivative Works; and
+* **(d)** If the Work includes a “NOTICE” text file as part of its distribution, then any
+Derivative Works that You distribute must include a readable copy of the
+attribution notices contained within such NOTICE file, excluding those notices
+that do not pertain to any part of the Derivative Works, in at least one of the
+following places: within a NOTICE text file distributed as part of the
+Derivative Works; within the Source form or documentation, if provided along
+with the Derivative Works; or, within a display generated by the Derivative
+Works, if and wherever such third-party notices normally appear. The contents of
+the NOTICE file are for informational purposes only and do not modify the
+License. You may add Your own attribution notices within Derivative Works that
+You distribute, alongside or as an addendum to the NOTICE text from the Work,
+provided that such additional attribution notices cannot be construed as
+modifying the License.
+
+You may add Your own copyright statement to Your modifications and may provide
+additional or different license terms and conditions for use, reproduction, or
+distribution of Your modifications, or for any such Derivative Works as a whole,
+provided Your use, reproduction, and distribution of the Work otherwise complies
+with the conditions stated in this License.
+
+#### 5. Submission of Contributions
+
+Unless You explicitly state otherwise, any Contribution intentionally submitted
+for inclusion in the Work by You to the Licensor shall be under the terms and
+conditions of this License, without any additional terms or conditions.
+Notwithstanding the above, nothing herein shall supersede or modify the terms of
+any separate license agreement you may have executed with Licensor regarding
+such Contributions.
+
+#### 6. Trademarks
+
+This License does not grant permission to use the trade names, trademarks,
+service marks, or product names of the Licensor, except as required for
+reasonable and customary use in describing the origin of the Work and
+reproducing the content of the NOTICE file.
+
+#### 7. Disclaimer of Warranty
+
+Unless required by applicable law or agreed to in writing, Licensor provides the
+Work (and each Contributor provides its Contributions) on an “AS IS” BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied,
+including, without limitation, any warranties or conditions of TITLE,
+NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are
+solely responsible for determining the appropriateness of using or
+redistributing the Work and assume any risks associated with Your exercise of
+permissions under this License.
+
+#### 8. Limitation of Liability
+
+In no event and under no legal theory, whether in tort (including negligence),
+contract, or otherwise, unless required by applicable law (such as deliberate
+and grossly negligent acts) or agreed to in writing, shall any Contributor be
+liable to You for damages, including any direct, indirect, special, incidental,
+or consequential damages of any character arising as a result of this License or
+out of the use or inability to use the Work (including but not limited to
+damages for loss of goodwill, work stoppage, computer failure or malfunction, or
+any and all other commercial damages or losses), even if such Contributor has
+been advised of the possibility of such damages.
+
+#### 9. Accepting Warranty or Additional Liability
+
+While redistributing the Work or Derivative Works thereof, You may choose to
+offer, and charge a fee for, acceptance of support, warranty, indemnity, or
+other liability obligations and/or rights consistent with this License. However,
+in accepting such obligations, You may act only on Your own behalf and on Your
+sole responsibility, not on behalf of any other Contributor, and only if You
+agree to indemnify, defend, and hold each Contributor harmless for any liability
+incurred by, or claims asserted against, such Contributor by reason of your
+accepting any such warranty or additional liability.
+
+_END OF TERMS AND CONDITIONS_
+
+### APPENDIX: How to apply the Apache License to your work
+
+To apply the Apache License to your work, attach the following boilerplate
+notice, with the fields enclosed by brackets `[]` replaced with your own
+identifying information. (Don't include the brackets!) The text should be
+enclosed in the appropriate comment syntax for the file format. We also
+recommend that a file or class name and description of purpose be included on
+the same “printed page” as the copyright notice for easier identification within
+third-party archives.
+
+    Copyright [yyyy] [name of copyright owner]
+    
+    Licensed under the Apache License, Version 2.0 (the "License");
+    you may not use this file except in compliance with the License.
+    You may obtain a copy of the License at
+    
+      http://www.apache.org/licenses/LICENSE-2.0
+    
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+
@@ -0,0 +1,5 @@
+# ST7789 i8080 Display Driver
+
+A kernel driver for the `ST7789` display panel over an i8080 (parallel) bus, built on ESP-IDF's `esp_lcd` component. Child of an i8080 bus controller device (e.g. `espressif,esp32-i8080` in `Platforms/platform-esp32`) - use `st7789-module` instead for SPI-attached ST7789 panels.
+
+License: [Apache v2.0](LICENSE-Apache-2.0.md)
@@ -0,0 +1,69 @@
+description: Sitronix ST7789 display panel over an i8080 (parallel) bus
+
+compatible: "sitronix,st7789-i8080"
+
+bus: i8080
+
+properties:
+  horizontal-resolution:
+    type: int
+    required: true
+    description: Horizontal resolution in pixels
+  vertical-resolution:
+    type: int
+    required: true
+    description: Vertical resolution in pixels
+  gap-x:
+    type: int
+    default: 0
+    description: X offset applied to all draw operations
+  gap-y:
+    type: int
+    default: 0
+    description: Y offset applied to all draw operations
+  swap-xy:
+    type: boolean
+    default: false
+    description: Swap the X and Y axes
+  mirror-x:
+    type: boolean
+    default: false
+    description: Mirror the X axis
+  mirror-y:
+    type: boolean
+    default: false
+    description: Mirror the Y axis
+  invert-color:
+    type: boolean
+    default: false
+    description: Invert the panel's color output
+  bgr-order:
+    type: boolean
+    default: false
+    description: Use BGR element order instead of RGB
+  pixel-clock-hz:
+    type: int
+    default: 16000000
+    description: i80 bus write-clock frequency in Hz
+  transaction-queue-depth:
+    type: int
+    default: 10
+    description: Size of the internal transaction queue
+  gamma-curve:
+    type: int
+    default: 1
+    min: 0
+    max: 3
+    description: Gamma curve preset index [0,3], sent via the MIPI DCS GAMSET (0x26) command at bring-up
+  pin-reset:
+    type: phandles
+    default: GPIO_PIN_SPEC_NONE
+    description: Reset GPIO pin
+  reset-active-high:
+    type: boolean
+    default: false
+    description: Whether the reset pin is active high
+  backlight:
+    type: phandle
+    default: "NULL"
+    description: Optional reference to this display's backlight device
@@ -0,0 +1,3 @@
+dependencies:
+  - TactilityKernel
+bindings: bindings
@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: Apache-2.0
+#pragma once
+
+#include <tactility/bindings/bindings.h>
+#include <drivers/st7789_i8080.h>
+
+DEFINE_DEVICETREE(st7789_i8080, struct St7789I8080Config)
@@ -0,0 +1,36 @@
+// SPDX-License-Identifier: Apache-2.0
+#pragma once
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#include <stdint.h>
+#include <stdbool.h>
+
+#include <tactility/device.h>
+#include <tactility/drivers/gpio.h>
+
+struct St7789I8080Config {
+    uint16_t horizontal_resolution;
+    uint16_t vertical_resolution;
+    int32_t gap_x;
+    int32_t gap_y;
+    bool swap_xy;
+    bool mirror_x;
+    bool mirror_y;
+    bool invert_color;
+    bool bgr_order;
+    uint32_t pixel_clock_hz;
+    uint8_t transaction_queue_depth;
+    // Gamma curve preset index [0,3], sent via the MIPI DCS GAMSET (0x26) command at bring-up.
+    uint8_t gamma_curve;
+    struct GpioPinSpec pin_reset;
+    bool reset_active_high;
+    // Optional reference to this display's backlight device, NULL if none.
+    struct Device* backlight;
+};
+
+#ifdef __cplusplus
+}
+#endif
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: Apache-2.0
+#pragma once
+
+#include <tactility/module.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+extern struct Module st7789_i8080_module;
+
+#ifdef __cplusplus
+}
+#endif
@@ -0,0 +1,32 @@
+// SPDX-License-Identifier: Apache-2.0
+#include <tactility/check.h>
+#include <tactility/driver.h>
+#include <tactility/module.h>
+
+extern "C" {
+
+extern Driver st7789_i8080_driver;
+
+static error_t start() {
+    /* We crash when construct fails, because if a single driver fails to construct,
+     * there is no guarantee that the previously constructed drivers can be destroyed */
+    check(driver_construct_add(&st7789_i8080_driver) == ERROR_NONE);
+    return ERROR_NONE;
+}
+
+static error_t stop() {
+    /* We crash when destruct fails, because if a single driver fails to destruct,
+     * there is no guarantee that the previously destroyed drivers can be recovered */
+    check(driver_remove_destruct(&st7789_i8080_driver) == ERROR_NONE);
+    return ERROR_NONE;
+}
+
+Module st7789_i8080_module = {
+    .name = "st7789_i8080",
+    .start = start,
+    .stop = stop,
+    .symbols = nullptr,
+    .internal = nullptr
+};
+
+} // extern "C"
@@ -0,0 +1,356 @@
+// SPDX-License-Identifier: Apache-2.0
+#include <drivers/st7789_i8080.h>
+#include <st7789_i8080_module.h>
+
+#include <tactility/check.h>
+#include <tactility/device.h>
+#include <tactility/driver.h>
+#include <tactility/drivers/display.h>
+#include <tactility/drivers/esp32_i8080.h>
+#include <tactility/drivers/i8080_controller.h>
+#include <tactility/error.h>
+#include <tactility/log.h>
+
+#include <esp_err.h>
+#include <esp_lcd_panel_commands.h>
+#include <esp_lcd_panel_io.h>
+#include <esp_lcd_panel_ops.h>
+#include <esp_lcd_panel_st7789.h>
+
+#include <freertos/semphr.h>
+#include <freertos/task.h>
+
+#include <cstdlib>
+
+#define TAG "ST7789I8080"
+#define GET_CONFIG(device) (static_cast<const St7789I8080Config*>((device)->config))
+
+// Maps gamma-curve devicetree index [0,3] to the MIPI DCS GAMSET (0x26) parameter value. Mirrors
+// the deprecated HAL's EspLcdSpiDisplay::setGammaCurve() (Drivers/EspLcdCompat) - note the
+// non-linear mapping, not index+1.
+static const uint8_t GAMMA_CURVE_VALUES[4] = { 0x01, 0x04, 0x02, 0x08 };
+
+namespace {
+
+// Panel bring-up commands beyond esp_lcd_panel_init()'s generic ST7789 sequence: gate/porch/power
+// control and gamma curves. Kept from the deprecated HAL's St7789i8080Display driver verbatim -
+// likely panel-specific tuning for the exact glass used on LilyGO T-HMI boards, not guaranteed
+// redundant with esp_lcd's built-in defaults, so preserved rather than dropped.
+struct LcdInitCmd {
+    uint8_t cmd;
+    uint8_t data[14];
+    uint8_t len;
+};
+
+constexpr LcdInitCmd ST7789_INIT_CMDS[] = {
+    {0x36, {0x08}, 1},
+    {0x3A, {0x05}, 1},
+    {0x20, {0}, 0},
+    {0xB2, {0x0B, 0x0B, 0x00, 0x33, 0x33}, 5},
+    {0xB7, {0x75}, 1},
+    {0xBB, {0x28}, 1},
+    {0xC0, {0x2C}, 1},
+    {0xC2, {0x01}, 1},
+    {0xC3, {0x1F}, 1},
+    {0xC6, {0x13}, 1},
+    {0xD0, {0xA7}, 1},
+    {0xD0, {0xA4, 0xA1}, 2},
+    {0xD6, {0xA1}, 1},
+    {0xE0, {0xF0, 0x05, 0x0A, 0x06, 0x06, 0x03, 0x2B, 0x32, 0x43, 0x36, 0x11, 0x10, 0x2B, 0x32}, 14},
+    {0xE1, {0xF0, 0x08, 0x0C, 0x0B, 0x09, 0x24, 0x2B, 0x22, 0x43, 0x38, 0x15, 0x16, 0x2F, 0x37}, 14},
+};
+
+} // namespace
+
+struct St7789I8080Internal {
+    esp_lcd_panel_io_handle_t io_handle;
+    esp_lcd_panel_handle_t panel_handle;
+    // See Ili9341Internal's identical field in ili9341-module for why this exists: draw_bitmap()
+    // must block until the transfer physically completes (DisplayApi's synchronous contract).
+    SemaphoreHandle_t draw_done_semaphore;
+};
+
+static bool IRAM_ATTR on_color_trans_done(esp_lcd_panel_io_handle_t, esp_lcd_panel_io_event_data_t*, void* user_ctx) {
+    auto* internal = static_cast<St7789I8080Internal*>(user_ctx);
+    BaseType_t high_task_woken = pdFALSE;
+    xSemaphoreGiveFromISR(internal->draw_done_semaphore, &high_task_woken);
+    return high_task_woken == pdTRUE;
+}
+
+static int pin_or_unused(const struct GpioPinSpec& pin) {
+    return pin.gpio_controller == nullptr ? -1 : static_cast<int>(pin.pin);
+}
+
+// region Driver lifecycle
+
+static error_t start(Device* device) {
+    auto* parent = device_get_parent(device);
+    check(device_get_type(parent) == &I8080_CONTROLLER_TYPE);
+
+    esp_lcd_i80_bus_handle_t bus_handle;
+    if (esp32_i8080_get_bus_handle(device, &bus_handle) != ERROR_NONE) {
+        LOG_E(TAG, "Failed to resolve i80 bus handle");
+        return ERROR_RESOURCE;
+    }
+
+    struct GpioPinSpec cs_pin;
+    if (esp32_i8080_get_cs_pin(device, &cs_pin) != ERROR_NONE) {
+        LOG_E(TAG, "Failed to resolve CS pin");
+        return ERROR_RESOURCE;
+    }
+
+    const auto* config = GET_CONFIG(device);
+
+    auto* internal = static_cast<St7789I8080Internal*>(malloc(sizeof(St7789I8080Internal)));
+    if (internal == nullptr) {
+        return ERROR_OUT_OF_MEMORY;
+    }
+
+    internal->draw_done_semaphore = xSemaphoreCreateBinary();
+    if (internal->draw_done_semaphore == nullptr) {
+        free(internal);
+        return ERROR_OUT_OF_MEMORY;
+    }
+
+    esp_lcd_panel_io_i80_config_t io_config = {
+        .cs_gpio_num = pin_or_unused(cs_pin),
+        .pclk_hz = config->pixel_clock_hz,
+        .trans_queue_depth = config->transaction_queue_depth,
+        .on_color_trans_done = on_color_trans_done,
+        .user_ctx = internal,
+        .lcd_cmd_bits = 8,
+        .lcd_param_bits = 8,
+        .dc_levels = {
+            .dc_idle_level = 0,
+            .dc_cmd_level = 0,
+            .dc_dummy_level = 0,
+            .dc_data_level = 1,
+        },
+        .flags = {
+            .cs_active_high = 0,
+            .reverse_color_bits = 0,
+            .swap_color_bytes = 1,
+            .pclk_active_neg = 0,
+            .pclk_idle_low = 0,
+        },
+    };
+
+    esp_err_t ret = esp_lcd_new_panel_io_i80(bus_handle, &io_config, &internal->io_handle);
+    if (ret != ESP_OK) {
+        LOG_E(TAG, "Failed to create panel IO: %s", esp_err_to_name(ret));
+        vSemaphoreDelete(internal->draw_done_semaphore);
+        free(internal);
+        return ERROR_RESOURCE;
+    }
+
+    esp_lcd_panel_dev_config_t panel_config = {
+        .reset_gpio_num = pin_or_unused(config->pin_reset),
+        .rgb_ele_order = config->bgr_order ? LCD_RGB_ELEMENT_ORDER_BGR : LCD_RGB_ELEMENT_ORDER_RGB,
+        .data_endian = LCD_RGB_DATA_ENDIAN_LITTLE,
+        .bits_per_pixel = 16,
+        .flags = { .reset_active_high = config->reset_active_high },
+        .vendor_config = nullptr,
+    };
+
+    ret = esp_lcd_new_panel_st7789(internal->io_handle, &panel_config, &internal->panel_handle);
+    if (ret != ESP_OK) {
+        LOG_E(TAG, "Failed to create panel: %s", esp_err_to_name(ret));
+        esp_lcd_panel_io_del(internal->io_handle);
+        vSemaphoreDelete(internal->draw_done_semaphore);
+        free(internal);
+        return ERROR_RESOURCE;
+    }
+
+    // Bring-up sequence, order matches the deprecated HAL's St7789i8080Display (proven correct on
+    // real T-HMI hardware). Every failure path below must clean up fully, same reasoning as
+    // ili9341-module's start().
+    bool ok =
+        esp_lcd_panel_reset(internal->panel_handle) == ESP_OK &&
+        esp_lcd_panel_init(internal->panel_handle) == ESP_OK;
+
+    if (ok) {
+        for (const auto& init_cmd : ST7789_INIT_CMDS) {
+            if (esp_lcd_panel_io_tx_param(internal->io_handle, init_cmd.cmd, init_cmd.data, init_cmd.len) != ESP_OK) {
+                ok = false;
+                break;
+            }
+        }
+    }
+
+    if (ok) {
+        int gap_x = config->swap_xy ? config->gap_y : config->gap_x;
+        int gap_y = config->swap_xy ? config->gap_x : config->gap_y;
+        ok = (gap_x == 0 && gap_y == 0) || esp_lcd_panel_set_gap(internal->panel_handle, gap_x, gap_y) == ESP_OK;
+    }
+    ok = ok && (!config->swap_xy || esp_lcd_panel_swap_xy(internal->panel_handle, true) == ESP_OK);
+    ok = ok && ((!config->mirror_x && !config->mirror_y) || esp_lcd_panel_mirror(internal->panel_handle, config->mirror_x, config->mirror_y) == ESP_OK);
+    ok = ok && (!config->invert_color || esp_lcd_panel_invert_color(internal->panel_handle, true) == ESP_OK);
+    ok = ok && (config->gamma_curve >= 4 || esp_lcd_panel_io_tx_param(internal->io_handle, LCD_CMD_GAMSET, &GAMMA_CURVE_VALUES[config->gamma_curve], 1) == ESP_OK);
+    ok = ok && esp_lcd_panel_disp_on_off(internal->panel_handle, true) == ESP_OK;
+
+    if (!ok) {
+        LOG_E(TAG, "Failed to bring up panel");
+        esp_lcd_panel_del(internal->panel_handle);
+        esp_lcd_panel_io_del(internal->io_handle);
+        vSemaphoreDelete(internal->draw_done_semaphore);
+        free(internal);
+        return ERROR_RESOURCE;
+    }
+
+    device_set_driver_data(device, internal);
+    return ERROR_NONE;
+}
+
+static error_t stop(Device* device) {
+    auto* internal = static_cast<St7789I8080Internal*>(device_get_driver_data(device));
+
+    error_t result = ERROR_NONE;
+
+    if (esp_lcd_panel_del(internal->panel_handle) != ESP_OK) {
+        LOG_E(TAG, "Failed to delete panel");
+        result = ERROR_RESOURCE;
+    }
+    if (esp_lcd_panel_io_del(internal->io_handle) != ESP_OK) {
+        LOG_E(TAG, "Failed to delete panel IO");
+        result = ERROR_RESOURCE;
+    }
+
+    vSemaphoreDelete(internal->draw_done_semaphore);
+    free(internal);
+    return result;
+}
+
+// endregion
+
+// region DisplayApi
+
+static error_t st7789_i8080_reset(Device* device) {
+    auto* internal = static_cast<St7789I8080Internal*>(device_get_driver_data(device));
+    return esp_lcd_panel_reset(internal->panel_handle) == ESP_OK ? ERROR_NONE : ERROR_RESOURCE;
+}
+
+static error_t st7789_i8080_init(Device* device) {
+    auto* internal = static_cast<St7789I8080Internal*>(device_get_driver_data(device));
+    return esp_lcd_panel_init(internal->panel_handle) == ESP_OK ? ERROR_NONE : ERROR_RESOURCE;
+}
+
+static error_t st7789_i8080_draw_bitmap(Device* device, int32_t x_start, int32_t y_start, int32_t x_end, int32_t y_end, const void* color_data) {
+    auto* internal = static_cast<St7789I8080Internal*>(device_get_driver_data(device));
+
+    xSemaphoreTake(internal->draw_done_semaphore, 0);
+
+    if (esp_lcd_panel_draw_bitmap(internal->panel_handle, x_start, y_start, x_end, y_end, color_data) != ESP_OK) {
+        return ERROR_RESOURCE;
+    }
+
+    xSemaphoreTake(internal->draw_done_semaphore, portMAX_DELAY);
+    return ERROR_NONE;
+}
+
+static error_t st7789_i8080_mirror(Device* device, bool x_axis, bool y_axis) {
+    auto* internal = static_cast<St7789I8080Internal*>(device_get_driver_data(device));
+    return esp_lcd_panel_mirror(internal->panel_handle, x_axis, y_axis) == ESP_OK ? ERROR_NONE : ERROR_RESOURCE;
+}
+
+static error_t st7789_i8080_swap_xy(Device* device, bool swap_axes) {
+    auto* internal = static_cast<St7789I8080Internal*>(device_get_driver_data(device));
+    return esp_lcd_panel_swap_xy(internal->panel_handle, swap_axes) == ESP_OK ? ERROR_NONE : ERROR_RESOURCE;
+}
+
+static bool st7789_i8080_get_swap_xy(Device* device) {
+    return GET_CONFIG(device)->swap_xy;
+}
+
+static bool st7789_i8080_get_mirror_x(Device* device) {
+    return GET_CONFIG(device)->mirror_x;
+}
+
+static bool st7789_i8080_get_mirror_y(Device* device) {
+    return GET_CONFIG(device)->mirror_y;
+}
+
+static error_t st7789_i8080_set_gap(Device* device, int32_t x_gap, int32_t y_gap) {
+    auto* internal = static_cast<St7789I8080Internal*>(device_get_driver_data(device));
+    return esp_lcd_panel_set_gap(internal->panel_handle, x_gap, y_gap) == ESP_OK ? ERROR_NONE : ERROR_RESOURCE;
+}
+
+static error_t st7789_i8080_invert_color(Device* device, bool invert_color_data) {
+    auto* internal = static_cast<St7789I8080Internal*>(device_get_driver_data(device));
+    return esp_lcd_panel_invert_color(internal->panel_handle, invert_color_data) == ESP_OK ? ERROR_NONE : ERROR_RESOURCE;
+}
+
+static error_t st7789_i8080_disp_on_off(Device* device, bool on_off) {
+    auto* internal = static_cast<St7789I8080Internal*>(device_get_driver_data(device));
+    return esp_lcd_panel_disp_on_off(internal->panel_handle, on_off) == ESP_OK ? ERROR_NONE : ERROR_RESOURCE;
+}
+
+static error_t st7789_i8080_disp_sleep(Device* device, bool sleep) {
+    auto* internal = static_cast<St7789I8080Internal*>(device_get_driver_data(device));
+    return esp_lcd_panel_disp_sleep(internal->panel_handle, sleep) == ESP_OK ? ERROR_NONE : ERROR_RESOURCE;
+}
+
+// swap_color_bytes=1 in the panel IO config means the i80 peripheral itself byte-swaps each
+// RGB565 pixel over the parallel bus, matching how ili9341-module's SPI variant needs
+// RGB565_SWAPPED - same reasoning, different transport.
+static enum DisplayColorFormat st7789_i8080_get_color_format(Device*) {
+    return DISPLAY_COLOR_FORMAT_RGB565_SWAPPED;
+}
+
+static uint16_t st7789_i8080_get_resolution_x(Device* device) {
+    return GET_CONFIG(device)->horizontal_resolution;
+}
+
+static uint16_t st7789_i8080_get_resolution_y(Device* device) {
+    return GET_CONFIG(device)->vertical_resolution;
+}
+
+static void st7789_i8080_get_frame_buffer(Device*, uint8_t, void** out_buffer) {
+    *out_buffer = nullptr;
+}
+
+static uint8_t st7789_i8080_get_frame_buffer_count(Device*) {
+    return 0;
+}
+
+static error_t st7789_i8080_get_backlight(Device* device, Device** backlight) {
+    auto* configured_backlight = GET_CONFIG(device)->backlight;
+    if (configured_backlight == nullptr) {
+        return ERROR_NOT_SUPPORTED;
+    }
+    *backlight = configured_backlight;
+    return ERROR_NONE;
+}
+
+// endregion
+
+static const DisplayApi st7789_i8080_display_api = {
+    .reset = st7789_i8080_reset,
+    .init = st7789_i8080_init,
+    .draw_bitmap = st7789_i8080_draw_bitmap,
+    .mirror = st7789_i8080_mirror,
+    .swap_xy = st7789_i8080_swap_xy,
+    .get_swap_xy = st7789_i8080_get_swap_xy,
+    .get_mirror_x = st7789_i8080_get_mirror_x,
+    .get_mirror_y = st7789_i8080_get_mirror_y,
+    .set_gap = st7789_i8080_set_gap,
+    .invert_color = st7789_i8080_invert_color,
+    .disp_on_off = st7789_i8080_disp_on_off,
+    .disp_sleep = st7789_i8080_disp_sleep,
+    .get_color_format = st7789_i8080_get_color_format,
+    .get_resolution_x = st7789_i8080_get_resolution_x,
+    .get_resolution_y = st7789_i8080_get_resolution_y,
+    .get_frame_buffer = st7789_i8080_get_frame_buffer,
+    .get_frame_buffer_count = st7789_i8080_get_frame_buffer_count,
+    .get_backlight = st7789_i8080_get_backlight,
+};
+
+Driver st7789_i8080_driver = {
+    .name = "st7789_i8080",
+    .compatible = (const char*[]) { "sitronix,st7789-i8080", nullptr },
+    .start_device = start,
+    .stop_device = stop,
+    .api = &st7789_i8080_display_api,
+    .device_type = &DISPLAY_TYPE,
+    .owner = &st7789_i8080_module,
+    .internal = nullptr
+};