TactilityCore improvements (#187)
FreeRTOS handles were stored plainly and they were deleted in the destructor of classes. This meant that if a class were to be copied, the destructor would be called twice on the same handles and lead to double-free. Seha on Discord suggested to fix this by using `std::unique_ptr` with a custom deletion function. The changes affect: - Thread - Semaphore - Mutex - StreamBuffer - Timer - MessageQueue - EventFlag Thread changes: - Removal of the hack with the `Data` struct - Thread's main body is now just a private static function inside the class. - The C functions were relocated to static class members PubSub changes: - Refactored pubsub into class - Renamed files to `PubSub` instead of `Pubsub` - `PubSubSubscription` is now a private inner struct and `PubSub` only exposes `SubscriptionHandle` Lockable, ScopedLockable, Mutex: - Added `lock()` method that locks indefinitely - Remove deprecated `acquire()` and `release()` methods - Removed `TtWaitForever` in favour of `portMAX_DELAY`
This commit is contained in:
committed by
GitHub
parent
c2edbad0fb
commit
686f7cce83
@@ -125,13 +125,13 @@ static void transitionAppToState(std::shared_ptr<app::AppInstance> app, app::Sta
|
||||
break;
|
||||
case app::StateShowing: {
|
||||
LoaderEvent event_showing = { .type = LoaderEventTypeApplicationShowing };
|
||||
tt_pubsub_publish(loader_singleton->pubsubExternal, &event_showing);
|
||||
loader_singleton->pubsubExternal->publish(&event_showing);
|
||||
app->setState(app::StateShowing);
|
||||
break;
|
||||
}
|
||||
case app::StateHiding: {
|
||||
LoaderEvent event_hiding = { .type = LoaderEventTypeApplicationHiding };
|
||||
tt_pubsub_publish(loader_singleton->pubsubExternal, &event_hiding);
|
||||
loader_singleton->pubsubExternal->publish(&event_hiding);
|
||||
app->setState(app::StateHiding);
|
||||
break;
|
||||
}
|
||||
@@ -174,7 +174,7 @@ static LoaderStatus startAppWithManifestInternal(
|
||||
transitionAppToState(new_app, app::StateShowing);
|
||||
|
||||
LoaderEvent event_external = { .type = LoaderEventTypeApplicationStarted };
|
||||
tt_pubsub_publish(loader_singleton->pubsubExternal, &event_external);
|
||||
loader_singleton->pubsubExternal->publish(&event_external);
|
||||
|
||||
return LoaderStatus::Ok;
|
||||
}
|
||||
@@ -265,7 +265,7 @@ static void stopAppInternal() {
|
||||
// WARNING: After this point we cannot change the app states from this method directly anymore as we don't have a lock!
|
||||
|
||||
LoaderEvent event_external = { .type = LoaderEventTypeApplicationStopped };
|
||||
tt_pubsub_publish(loader_singleton->pubsubExternal, &event_external);
|
||||
loader_singleton->pubsubExternal->publish(&event_external);
|
||||
|
||||
if (instance_to_resume != nullptr) {
|
||||
if (result_set) {
|
||||
|
||||
Reference in New Issue
Block a user