TactilityCore improvements (#187)

FreeRTOS handles were stored plainly and they were deleted in the destructor of classes.
This meant that if a class were to be copied, the destructor would be called twice on the same handles and lead to double-free.

Seha on Discord suggested to fix this by using `std::unique_ptr` with a custom deletion function.

The changes affect:
- Thread
- Semaphore
- Mutex
- StreamBuffer
- Timer
- MessageQueue
- EventFlag

Thread  changes:
- Removal of the hack with the `Data` struct
- Thread's main body is now just a private static function inside the class.
- The C functions were relocated to static class members

PubSub changes:
- Refactored pubsub into class
- Renamed files to `PubSub` instead of `Pubsub`
- `PubSubSubscription` is now a private inner struct and `PubSub` only exposes `SubscriptionHandle`

Lockable, ScopedLockable, Mutex:
- Added `lock()` method that locks indefinitely
- Remove deprecated `acquire()` and `release()` methods
- Removed `TtWaitForever` in favour of `portMAX_DELAY`

Tactility/Source/service/gui/Gui.cpp

@@ -35,7 +35,7 @@ Gui* gui_alloc() {
         &guiMain,
         nullptr
     );
-    instance->loader_pubsub_subscription = tt_pubsub_subscribe(loader::getPubsub(), &onLoaderMessage, instance);
+    instance->loader_pubsub_subscription = loader::getPubsub()->subscribe(&onLoaderMessage, instance);
     tt_check(lvgl::lock(1000 / portTICK_PERIOD_MS));
     instance->keyboardGroup = lv_group_create();
     auto* screen_root = lv_scr_act();
@@ -90,7 +90,7 @@ void unlock() {
 void requestDraw() {
     assert(gui);
     ThreadId thread_id = gui->thread->getId();
-    thread_flags_set(thread_id, GUI_THREAD_FLAG_DRAW);
+    Thread::setFlags(thread_id, GUI_THREAD_FLAG_DRAW);
 }
 
 void showApp(std::shared_ptr<app::AppContext> app) {
@@ -120,19 +120,19 @@ static int32_t guiMain(TT_UNUSED void* p) {
     Gui* local_gui = gui;
 
     while (true) {
-        uint32_t flags = thread_flags_wait(
+        uint32_t flags = Thread::awaitFlags(
             GUI_THREAD_FLAG_ALL,
-            TtFlagWaitAny,
-            TtWaitForever
+            EventFlag::WaitAny,
+            portMAX_DELAY
         );
         // Process and dispatch draw call
         if (flags & GUI_THREAD_FLAG_DRAW) {
-            thread_flags_clear(GUI_THREAD_FLAG_DRAW);
+            Thread::clearFlags(GUI_THREAD_FLAG_DRAW);
             redraw(local_gui);
         }
 
         if (flags & GUI_THREAD_FLAG_EXIT) {
-            thread_flags_clear(GUI_THREAD_FLAG_EXIT);
+            Thread::clearFlags(GUI_THREAD_FLAG_EXIT);
             break;
         }
     }
@@ -159,7 +159,7 @@ public:
         lock();
 
         ThreadId thread_id = gui->thread->getId();
-        thread_flags_set(thread_id, GUI_THREAD_FLAG_EXIT);
+        Thread::setFlags(thread_id, GUI_THREAD_FLAG_EXIT);
         gui->thread->join();
         delete gui->thread;
 

Tactility/Source/service/loader/Loader.cpp

@@ -125,13 +125,13 @@ static void transitionAppToState(std::shared_ptr<app::AppInstance> app, app::Sta
             break;
         case app::StateShowing: {
             LoaderEvent event_showing = { .type = LoaderEventTypeApplicationShowing };
-            tt_pubsub_publish(loader_singleton->pubsubExternal, &event_showing);
+            loader_singleton->pubsubExternal->publish(&event_showing);
             app->setState(app::StateShowing);
             break;
         }
         case app::StateHiding: {
             LoaderEvent event_hiding = { .type = LoaderEventTypeApplicationHiding };
-            tt_pubsub_publish(loader_singleton->pubsubExternal, &event_hiding);
+            loader_singleton->pubsubExternal->publish(&event_hiding);
             app->setState(app::StateHiding);
             break;
         }
@@ -174,7 +174,7 @@ static LoaderStatus startAppWithManifestInternal(
     transitionAppToState(new_app, app::StateShowing);
 
     LoaderEvent event_external = { .type = LoaderEventTypeApplicationStarted };
-    tt_pubsub_publish(loader_singleton->pubsubExternal, &event_external);
+    loader_singleton->pubsubExternal->publish(&event_external);
 
     return LoaderStatus::Ok;
 }
@@ -265,7 +265,7 @@ static void stopAppInternal() {
     // WARNING: After this point we cannot change the app states from this method directly anymore as we don't have a lock!
 
     LoaderEvent event_external = { .type = LoaderEventTypeApplicationStopped };
-    tt_pubsub_publish(loader_singleton->pubsubExternal, &event_external);
+    loader_singleton->pubsubExternal->publish(&event_external);
 
     if (instance_to_resume != nullptr) {
         if (result_set) {

Tactility/Source/service/loader/Loader.h

@@ -1,8 +1,8 @@
 #pragma once
 
-#include "app/AppManifest.h"
 #include "Bundle.h"
-#include "Pubsub.h"
+#include "PubSub.h"
+#include "app/AppManifest.h"
 #include "service/ServiceManifest.h"
 #include <memory>
 

Tactility/Source/service/screenshot/ScreenshotTask.cpp

@@ -41,7 +41,7 @@ bool ScreenshotTask::isFinished() {
 
 void ScreenshotTask::setFinished() {
     auto scoped_lockable = mutex.scoped();
-    scoped_lockable->lock(TtWaitForever);
+    scoped_lockable->lock();
     finished = true;
 }
 

Tactility/Source/service/statusbar/Statusbar.cpp

@@ -138,11 +138,11 @@ private:
     std::unique_ptr<service::Paths> paths;
 
     void lock() const {
-        tt_check(mutex.acquire(TtWaitForever) == TtStatusOk);
+        mutex.lock();
     }
 
     void unlock() const {
-        tt_check(mutex.release() == TtStatusOk);
+        mutex.unlock();
     }
 
     void updateWifiIcon() {