TactilityCore improvements (#187)

FreeRTOS handles were stored plainly and they were deleted in the destructor of classes.
This meant that if a class were to be copied, the destructor would be called twice on the same handles and lead to double-free.

Seha on Discord suggested to fix this by using `std::unique_ptr` with a custom deletion function.

The changes affect:
- Thread
- Semaphore
- Mutex
- StreamBuffer
- Timer
- MessageQueue
- EventFlag

Thread  changes:
- Removal of the hack with the `Data` struct
- Thread's main body is now just a private static function inside the class.
- The C functions were relocated to static class members

PubSub changes:
- Refactored pubsub into class
- Renamed files to `PubSub` instead of `Pubsub`
- `PubSubSubscription` is now a private inner struct and `PubSub` only exposes `SubscriptionHandle`

Lockable, ScopedLockable, Mutex:
- Added `lock()` method that locks indefinitely
- Remove deprecated `acquire()` and `release()` methods
- Removed `TtWaitForever` in favour of `portMAX_DELAY`
This commit is contained in:
Ken Van Hoeylandt
2025-01-25 17:29:11 +01:00
committed by GitHub
parent c2edbad0fb
commit 686f7cce83
60 changed files with 711 additions and 831 deletions
+15 -17
View File
@@ -1,63 +1,61 @@
#include <Check.h>
#include "app/wifimanage/WifiManagePrivate.h"
namespace tt::app::wifimanage {
void State::setScanning(bool isScanning) {
tt_check(mutex.acquire(TtWaitForever) == TtStatusOk);
mutex.lock();
scanning = isScanning;
scannedAfterRadioOn |= isScanning;
tt_check(mutex.release() == TtStatusOk);
mutex.unlock();
}
void State::setRadioState(service::wifi::RadioState state) {
tt_check(mutex.acquire(TtWaitForever) == TtStatusOk);
mutex.lock();
radioState = state;
if (radioState == service::wifi::RadioState::Off) {
scannedAfterRadioOn = false;
}
tt_check(mutex.release() == TtStatusOk);
mutex.unlock();
}
service::wifi::RadioState State::getRadioState() const {
tt_check(mutex.acquire(TtWaitForever) == TtStatusOk);
mutex.lock();
auto result = radioState;
tt_check(mutex.release() == TtStatusOk);
mutex.unlock();
return result;
}
bool State::isScanning() const {
tt_check(mutex.acquire(TtWaitForever) == TtStatusOk);
mutex.lock();
bool result = scanning;
tt_check(mutex.release() == TtStatusOk);
mutex.unlock();
return result;
}
const std::vector<service::wifi::ApRecord>& State::lockApRecords() const {
tt_check(mutex.acquire(TtWaitForever) == TtStatusOk);
mutex.lock();
return apRecords;
}
void State::unlockApRecords() const {
tt_check(mutex.release() == TtStatusOk);
mutex.unlock();
}
void State::updateApRecords() {
tt_check(mutex.acquire(TtWaitForever) == TtStatusOk);
mutex.lock();
apRecords = service::wifi::getScanResults();
tt_check(mutex.release() == TtStatusOk);
mutex.unlock();
}
void State::setConnectSsid(const std::string& ssid) {
tt_check(mutex.acquire(TtWaitForever) == TtStatusOk);
mutex.lock();
connectSsid = ssid;
tt_check(mutex.release() == TtStatusOk);
mutex.unlock();
}
std::string State::getConnectSsid() const {
tt_check(mutex.acquire(TtWaitForever) == TtStatusOk);
mutex.lock();
auto result = connectSsid;
tt_check(mutex.release() == TtStatusOk);
return result;
}