Remove explicit app closing function (#618)

Tactility/Source/app/addgps/AddGps.cpp

@@ -217,7 +217,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             case APP_EVENT_RESULT:

Tactility/Source/app/alertdialog/AlertDialog.cpp

@@ -114,7 +114,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
             break;
         }
         if (event.type == APP_EVENT_CLOSE) {
-            app_manager_finish(appInstanceId); // no-op: modal children never supersede anything
             break;
         }
     }

Tactility/Source/app/appdetails/AppDetails.cpp

@@ -111,7 +111,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
     ctx.targetAppId = (argc > 0) ? argv[0] : std::string();
     if (app_manager_find_manifest(ctx.targetAppId.c_str(), &ctx.targetManifest) != ERROR_NONE) {
         LOG_W(TAG, "App %s not found", ctx.targetAppId.c_str());
-        app_manager_finish(appInstanceId);
         return 0;
     }
 
@@ -129,14 +128,12 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             case APP_EVENT_RESULT:
                 if (event.result.launch_id == ctx.pendingUninstallDialogId) {
                     if (event.result.result == 0) { // 0 = Yes
                         app_uninstall(ctx.targetManifest.id);
-                        app_manager_finish(appInstanceId);
                         shouldClose = true;
                     }
                     app_manager_stop(event.result.launch_id);

Tactility/Source/app/apphub/AppHubApp.cpp

@@ -215,7 +215,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/apphubdetails/AppHubDetailsApp.cpp

@@ -244,7 +244,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             case APP_EVENT_RESULT: {

Tactility/Source/app/applist/AppList.cpp

@@ -93,7 +93,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
             break;
         }
         if (event.type == APP_EVENT_CLOSE) {
-            app_manager_finish(appInstanceId);
             break;
         }
     }

Tactility/Source/app/appsettings/AppSettings.cpp

@@ -104,7 +104,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/apwebserver/ApWebServer.cpp

@@ -140,7 +140,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/audiosettings/AudioSettings.cpp

@@ -229,7 +229,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/boot/Boot.cpp

@@ -310,7 +310,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
             break;
         }
         if (event.type == APP_EVENT_CLOSE) {
-            app_manager_finish(appInstanceId);
             break;
         }
     }

Tactility/Source/app/btmanage/BtManage.cpp

@@ -249,7 +249,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/btpeersettings/BtPeerSettings.cpp

@@ -213,7 +213,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             case APP_EVENT_RESULT:
@@ -226,7 +225,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
                         }
                     }
                     bluetooth::unpair(ctx.addr);
-                    app_manager_finish(appInstanceId);
                     shouldClose = true;
                 }
                 app_manager_stop(event.result.launch_id);

Tactility/Source/app/chat/ChatApp.cpp

@@ -199,7 +199,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/crashdiagnostics/CrashDiagnostics.cpp

@@ -168,15 +168,12 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
             }
             switch (event.type) {
             case APP_EVENT_CLOSE:
-                    app_manager_finish(appInstanceId);
                     shouldClose = true;
                     break;
                 default:
                     break;
             }
         }
-    } else {
-        app_manager_finish(appInstanceId);
     }
 
     window_manager_remove(window);

Tactility/Source/app/development/Development.cpp

@@ -171,7 +171,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         LOG_E(TAG, "Service not found");
         // No window/subscription was ever created - matches the old model, where onCreate()
         // aborting the app meant onShow() was never called either.
-        app_manager_finish(appInstanceId);
         return 0;
     }
 
@@ -204,7 +203,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/files/FilesApp.cpp

@@ -44,7 +44,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             case APP_EVENT_RESULT:

Tactility/Source/app/fileselection/FileSelection.cpp

@@ -74,7 +74,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
             break;
         }
         if (event.type == APP_EVENT_CLOSE) {
-            app_manager_finish(appInstanceId); // no-op: modal children never supersede anything
             break;
         }
     }

Tactility/Source/app/gpssettings/GpsSettings.cpp

@@ -282,7 +282,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             case APP_EVENT_RESULT:

Tactility/Source/app/grovesettings/GroveSettings.cpp

@@ -107,7 +107,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/i2cscanner/I2cScanner.cpp

@@ -403,7 +403,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         switch (event.type) {
             case APP_EVENT_CLOSE:
                 stopScanningIfRunning(&ctx);
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/imageviewer/ImageViewer.cpp

@@ -103,7 +103,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/inputdialog/InputDialog.cpp

@@ -123,7 +123,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
             break;
         }
         if (event.type == APP_EVENT_CLOSE) {
-            app_manager_finish(appInstanceId); // no-op: modal children never supersede anything
             break;
         }
     }

Tactility/Source/app/kerneldisplay/KernelDisplay.cpp

@@ -323,7 +323,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         switch (event.type) {
             case APP_EVENT_CLOSE:
                 persistIfUpdated(ctx);
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/keyboard/KeyboardSettings.cpp

@@ -224,7 +224,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         switch (event.type) {
             case APP_EVENT_CLOSE:
                 persistIfUpdated(ctx);
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/launcher/Launcher.cpp

@@ -248,7 +248,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
             break;
         }
         if (event.type == APP_EVENT_CLOSE) {
-            app_manager_finish(appInstanceId);
             break;
         }
     }

Tactility/Source/app/localesettings/LocaleSettings.cpp

@@ -159,7 +159,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/notes/Notes.cpp

@@ -204,7 +204,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             case APP_EVENT_RESULT:

Tactility/Source/app/power/Power.cpp

@@ -255,7 +255,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/poweroff/PowerOff.cpp

@@ -150,7 +150,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/screenshot/Screenshot.cpp

@@ -264,7 +264,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/selectiondialog/SelectionDialog.cpp

@@ -116,7 +116,6 @@ int32_t appMain(AppInstanceId appInstanceId, int argc, char* argv[]) {
             break;
         }
         if (event.type == APP_EVENT_CLOSE) {
-            app_manager_finish(appInstanceId); // no-op: modal children never supersede anything
             break;
         }
     }

Tactility/Source/app/settings/Settings.cpp

@@ -91,7 +91,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
             break;
         }
         if (event.type == APP_EVENT_CLOSE) {
-            app_manager_finish(appInstanceId);
             break;
         }
     }

Tactility/Source/app/setup/Setup.cpp

@@ -157,9 +157,9 @@ void onContinueClicked(lv_event_t* event) {
             break;
         case Phase::Done: {
             markCompleted();
-            // Async, non-blocking - must NOT call app_manager_stop()/app_manager_finish()
-            // directly here: this callback runs ON the LVGL task, and app-lifecycle
-            // transitions must happen on this app's own thread (woken via app_event_await()).
+            // Async, non-blocking - must NOT call app_manager_stop() directly here: this
+            // callback runs ON the LVGL task, and app-lifecycle transitions must happen on this
+            // app's own thread (woken via app_event_await()), which closes by returning.
             AppEvent closeEvent { .type = APP_EVENT_CLOSE, .timestamp = 0, .result = {} };
             app_event_emit(ctx->appInstanceId, &closeEvent);
             break;
@@ -243,7 +243,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             case APP_EVENT_RESULT:

Tactility/Source/app/systeminfo/SystemInfo.cpp

@@ -433,7 +433,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/timedatesettings/TimeDateSettings.cpp

@@ -171,7 +171,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             case APP_EVENT_RESULT:

Tactility/Source/app/timezone/TimeZone.cpp

@@ -253,7 +253,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
             break;
         }
         if (event.type == APP_EVENT_CLOSE) {
-            app_manager_finish(appInstanceId); // no-op: modal children never supersede anything
             break;
         }
     }

Tactility/Source/app/touchcalibration/TouchCalibration.cpp

@@ -172,10 +172,10 @@ void onPress(lv_event_t* event) {
         return;
     }
 
-    // Async, non-blocking - must NOT call app_manager_stop()/app_manager_finish() directly
-    // here: this callback runs ON the LVGL task, and app-lifecycle transitions must happen on
-    // this app's own thread (woken up via app_event_await() below). The result (Ok/Error) is
-    // reported by appMain() itself when it returns, based on ctx.calibrationApplied.
+    // Async, non-blocking - must NOT call app_manager_stop() directly here: this callback runs
+    // ON the LVGL task, and app-lifecycle transitions must happen on this app's own thread
+    // (woken up via app_event_await() below), which closes by returning. The result (Ok/Error)
+    // is reported by appMain() itself when it returns, based on ctx.calibrationApplied.
     AppEvent closeEvent { .type = APP_EVENT_CLOSE, .timestamp = 0, .result = {} };
     app_event_emit(ctx->appInstanceId, &closeEvent);
 }
@@ -247,7 +247,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/trackball/TrackballSettings.cpp

@@ -287,7 +287,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         switch (event.type) {
             case APP_EVENT_CLOSE:
                 persistIfUpdated(ctx);
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/usbsettings/UsbSettings.cpp

@@ -99,7 +99,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/webserversettings/WebServerSettings.cpp

@@ -376,7 +376,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/wifiapsettings/WifiApSettings.cpp

@@ -228,7 +228,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             case APP_EVENT_RESULT:
@@ -243,7 +242,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
                         ) {
                             service::wifi::disconnect();
                         }
-                        app_manager_finish(appInstanceId);
                         shouldClose = true;
                     }
                 }

Tactility/Source/app/wificonnect/WifiConnect.cpp

@@ -334,7 +334,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default:

Tactility/Source/app/wifimanage/WifiManage.cpp

@@ -160,7 +160,6 @@ int32_t appMain(uint32_t appInstanceId, int argc, char* argv[]) {
         }
         switch (event.type) {
             case APP_EVENT_CLOSE:
-                app_manager_finish(appInstanceId);
                 shouldClose = true;
                 break;
             default: