Fix profile update persistence and stale cache

dbTools/profile.js

@@ -23,7 +23,9 @@ userDB = (DB) => {
 
     DB.updateProfile = async (profileid, profileObj) => {
         let tempProfile = profileObj.toObj();
-        const query = { _id: profileid };
+        if (!DB.ObjectID.isValid(profileid)) return false;
+        const _id = DB.ObjectID(profileid);
+        const query = { _id };
         const update = {
             $set: {
                 profile: tempProfile.profile,
@@ -34,6 +36,7 @@ userDB = (DB) => {
             console.log(err);
             return false;
         });
+        if (userProfileCache[profileid]) delete userProfileCache[profileid];
         return r;
     }
 

routes/profile.js

@@ -760,16 +760,28 @@ DB.getDB.then((DB) => {
  *                   type: string
  */
     router.post("/myProfile", async (req, res) => {
+        try {
             let profile = {
                 userid: getUserId(req),
                 profile: req.body.profile,
                 data: req.body.data
             };
             let profileObj = new Profile(profile); //validates profile
-        DB.updateProfile(getProfileId(req), profileObj);
+            const updateRes = await DB.updateProfile(getProfileId(req), profileObj);
+            if (!updateRes || !updateRes.matchedCount) {
+                return res.status(400).json({
+                    status: "Could not update profile"
+                });
+            }
             return res.json({
                 status: "ok"
             });
+        } catch (error) {
+            console.error("Error updating myProfile", error);
+            return res.status(500).json({
+                status: "Internal server error"
+            });
+        }
     });
 
     /**